Add Sentinel to telemetry #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be useful to track usage of the root sentinel config file (`sentinel.hcl`) to determine how many users use the extension for Sentinel.
radeksimko
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Just to help interpret the numbers, I expect that similar to Nomad, which accepts arbitrary filenames via the CLI, we can only detect the ones which follow naming conventions, correct?
i.e. Assuming the docs are true, then sentinel.hcl is just a convention, which isn't enforced, right?
Either way - great addition, thanks for the catch!
That is true ... for the CLI. One saving grace is that TFC/TFE doesn't allow you to change the root config file (sentinel.hcl or sentinel.json) so it should be more common. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful to track usage of the root sentinel config file (
sentinel.hcl) to determine how many users use the extension for Sentinel.